Skip to content

Conversation

@dereuromark
Copy link
Member

Can we do this for the skeleton for new apps?

Refs
cakephp/cakephp#18764

@dereuromark dereuromark added this to the 5.x milestone Jun 26, 2025
@mirko-pagliai
Copy link
Contributor

But I don't see any problems at the moment.
No method currently explicitly reports void.
The user mentions AppController::beforeFilter(), but that's not explicit either.

If we want to proceed in this direction, it should be made explicit everywhere (all events of all classes that extend Controller) ???

@dereuromark
Copy link
Member Author

dereuromark commented Jun 26, 2025

This will happen, but for BC reasons we cannot change the core (in a patch) release. Generated code and this boilerplate code can be adjusted safely usually.

@markstory
Copy link
Member

Yes, this is totally fine to do in the skeleton.

@markstory markstory merged commit df3967a into 5.x Jun 29, 2025
3 checks passed
@markstory markstory deleted the 5.x-events branch June 29, 2025 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants